Put the fips go check under an if clause #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deva26
approved these changes
Mar 12, 2021
deva26
added a commit
that referenced
this pull request
Mar 12, 2021
* disable fail fast and correct file name (#76) * remove the test- prefix from tag while pushing test images (#83) * Use appropriate go version according to the tag (#63) * use appropriate go version according to tag * removing fips comment from normal go * setup normal go for the release scripts too * update e2e workflow since go version differs by tag now * move go versions into the script * Increase the timeout and deal with hyphens in folder names (#82) * add a patch to increase the timeout * correct the path * added better echo statements while testing * gke channel change (#102) * shebang fix (#109) * Switch release builder branches for building releases (#108) * use the specific build branch for the release builder * use appropriate version for the branches too * add ingress patch (#116) * Upgrade machine types and count (#115) * upgrade machine types * add echo statements and remove count * sudo with env (#129) * imagepull policy (#136) * update eks ingress patch for 1.8 (#135) * skip the endpointslice package for 1.17 entirely (#147) * change aks vm type (#153) * Fix the workflow failures for 1.7.8 (#160) * initial scripts for EKSD (#167) * Prepare a version matrix for istio supported k8s versions (#66) * rebase latest changes * add a python script for version check * reversing the condition * add new versions for e2e tests * disable stackdriver while grepping for packages (#174) * Release builder fixes for FIPS builds (#188) * run the setup go scripts in the same shell * use normal go for building binaries even for fips * Fips distroless (#196) * distroless base image change for pilot and operator * refactor create release script * nits * nits * add a default for make release workflow (#204) * Add an echo for the go version of the binary (#195) * add an echo for the go version of the binary * more checks for the golang version * chagne the variable names * adjusted the variable names * Disable tests if the k8s version is not supported (#206) * disable tests if the k8s version is not supported * change the varible names to something more accurate * change the variable name used to decide the script * Add the eksd tests job (#181) * add the eksd tests job * no need to clone the repo again * added basedir to eksd cluster scripts * make versions consistent across the jobs * add eks tests as dependency of eksd tests * use better variable names * fix the merge errors * Generate manifest yamls using python script (#213) * generate the release builder manifests with the help of python * point that both yamls are generated with a single script * put the fips go check under an if clause (#242) Co-authored-by: Kuntal Majumder <12135951+hellozee@users.noreply.github.com>
deva26
added a commit
that referenced
this pull request
Mar 15, 2021
* disable fail fast and correct file name (#76) * remove the test- prefix from tag while pushing test images (#83) * Use appropriate go version according to the tag (#63) * use appropriate go version according to tag * removing fips comment from normal go * setup normal go for the release scripts too * update e2e workflow since go version differs by tag now * move go versions into the script * Increase the timeout and deal with hyphens in folder names (#82) * add a patch to increase the timeout * correct the path * added better echo statements while testing * gke channel change (#102) * shebang fix (#109) * Switch release builder branches for building releases (#108) * use the specific build branch for the release builder * use appropriate version for the branches too * add ingress patch (#116) * Upgrade machine types and count (#115) * upgrade machine types * add echo statements and remove count * sudo with env (#129) * imagepull policy (#136) * update eks ingress patch for 1.8 (#135) * skip the endpointslice package for 1.17 entirely (#147) * change aks vm type (#153) * Fix the workflow failures for 1.7.8 (#160) * initial scripts for EKSD (#167) * Prepare a version matrix for istio supported k8s versions (#66) * rebase latest changes * add a python script for version check * reversing the condition * add new versions for e2e tests * disable stackdriver while grepping for packages (#174) * Release builder fixes for FIPS builds (#188) * run the setup go scripts in the same shell * use normal go for building binaries even for fips * Fips distroless (#196) * distroless base image change for pilot and operator * refactor create release script * nits * nits * add a default for make release workflow (#204) * Add an echo for the go version of the binary (#195) * add an echo for the go version of the binary * more checks for the golang version * chagne the variable names * adjusted the variable names * Disable tests if the k8s version is not supported (#206) * disable tests if the k8s version is not supported * change the varible names to something more accurate * change the variable name used to decide the script * Add the eksd tests job (#181) * add the eksd tests job * no need to clone the repo again * added basedir to eksd cluster scripts * make versions consistent across the jobs * add eks tests as dependency of eksd tests * use better variable names * fix the merge errors * Generate manifest yamls using python script (#213) * generate the release builder manifests with the help of python * point that both yamls are generated with a single script * put the fips go check under an if clause (#242) * update the python script to gen the manifest (#250) Co-authored-by: Kuntal Majumder <12135951+hellozee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.