Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jit: add more test cases for add/sub operations. #97

Merged
merged 2 commits into from
Dec 30, 2021
Merged

jit: add more test cases for add/sub operations. #97

merged 2 commits into from
Dec 30, 2021

Conversation

mathetake
Copy link
Member

This completes the support of add/sub operations for all types!

@mathetake
jit: add more test cases for add/sub operations.
2993350 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
fix
e81b318 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake mentioned this pull request Dec 30, 2021
Closed
codefromthecrypt
codefromthecrypt approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what makes these easy to review is that the "check the stack" values make sense.

@mathetake mathetake merged commit acc4cac into main Dec 30, 2021
@mathetake mathetake deleted the add-sub branch December 30, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathetake @codefromthecrypt