Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setUserId instead of setCustomVariable #3

Closed
GitPuffy opened this issue Nov 21, 2016 · 2 comments
Closed

Use setUserId instead of setCustomVariable #3

GitPuffy opened this issue Nov 21, 2016 · 2 comments
Assignees

Comments

@GitPuffy
Copy link

GitPuffy commented Nov 21, 2016

In regards to e781ec2

I changed the line $tracker->setCustomVariable($userEmailCustomVar, 'User email', $userEmail); to

$tracker->setUserId($userEmail);

And now Piwik records the email account as the user ID and displays the user account on the main Piwik dashboard view.

I don't know if this is any better in the long run from how you programmed it but I am passing along this tidbit in case you feel it is an even better solution and want to change it in a future release.

Thanks!

@tetsuo13
Copy link
Owner

I misread your comment at first. Your suggestion looks like it may be a better solution than stuffing it into a custom variable. Let me experiment with it to see the differences in Piwik's reporting.

tetsuo13 added a commit that referenced this issue Dec 7, 2016
Much better implementation of associating user data than using custom
variable originally implemented in #2 since a user may access
Roundcube multiple times across different devices or browsers and this
will aggregate all data under a single profile.
@tetsuo13
Copy link
Owner

tetsuo13 commented Dec 7, 2016

I've made the changes to use user ID instead and released version 2.0.0. This is much better than was implemented in #2 since it creates a profile in Piwik.

Thank you!

@tetsuo13 tetsuo13 self-assigned this Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants