Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serial number size mismatch with stlink_open_usb() #680

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

ZogFluff
Copy link
Contributor

@ZogFluff ZogFluff commented Mar 6, 2018

No description provided.

@xor-gate
Copy link
Member

xor-gate commented Mar 6, 2018

Looks good, i'm thinking where this has caused problems?

@ZogFluff
Copy link
Contributor Author

ZogFluff commented Mar 6, 2018

In my case I am using a STM32F410 Nucleo board and the serial number is long, the short array in stlib_prob_usb_devs() results in a partial serial number being captured, but the serial number compare in stlink_open_usb() is expecting a larger serial number and the serial compare in the while loop fails.

I think this would only be seen when the serial number is longer.

@xor-gate
Copy link
Member

xor-gate commented Mar 6, 2018

Yes I agree. Thanks for fixing.

@xor-gate xor-gate added this to the Next milestone Mar 6, 2018
@xor-gate xor-gate merged commit b69c1d5 into stlink-org:master Mar 6, 2018
@ZogFluff
Copy link
Contributor Author

ZogFluff commented Mar 6, 2018

:-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants