retry Salesforce access token requests #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGibson27
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Retries requests to retrieve an access token from Salesforce.
Why are we doing this? How does it help us?
Starting five days ago Salesforce OAuth token API requests started failing intermittently. Previously this happened so infrequently that it could the errors could be handled manually. Now they are happening much more frequently necessitating a different solution. This helps us by making it so I don't have to re-run the batch job multiple times to get it to complete every day and so that we don't have to clean up after incomplete runs.
How should this be manually tested?
I don't know of a good way to test it since this is only happening in production. Run a couple of sample transactions through and make sure they appear in Slack and Salesforce.
How should this change be communicated to end-users?
N/A
Are there any smells or added technical debt to note?
No.
What are the relevant tickets?
Off-sprint.
Have you done the following, if applicable:
(optional: add explanation between parentheses)
TODOs / next steps: