Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Commit

Permalink
make view-validation failures warnings, not errors
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewGibson27 committed Dec 23, 2020
1 parent 99c3706 commit d3b1856
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 11 deletions.
8 changes: 4 additions & 4 deletions server/routes/pixel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import jwt from 'jsonwebtoken';

import { TRACKER_JWT_SECRET } from '../config';
import { TrackerTokenPayload } from '../types';
import reportError from '../utils/report-error';
import logError from '../utils/log-error';
import reportMessage from '../utils/report-message';
import logMessage from '../utils/log-message';
import View from '../models/view';
import noCacheMiddleware from '../middleware/no-cache';

Expand Down Expand Up @@ -46,8 +46,8 @@ router.get('/pixel.gif', async (req, res) => {
`Logged view | Canonical: ${view.canonical} | Domain: ${view.domain} | Source: ${view.source}`
);
} catch (error) {
logError(error);
reportError(error);
logMessage(error.message);
reportMessage({ message: error.message });
} finally {
res
.set({
Expand Down
4 changes: 4 additions & 0 deletions server/utils/log-message.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export default function logMessage(message: string): void {
// eslint-disable-next-line no-console
console.error(message);
}
6 changes: 2 additions & 4 deletions server/utils/report-error.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { captureException, withScope } from '@sentry/node';
import { captureException } from '@sentry/node';

export default function reportError(error: Error): void {
withScope(() => {
captureException(error);
});
captureException(error);
}
3 changes: 0 additions & 3 deletions server/utils/report-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,5 @@ export default function reportMessage({
message: string;
severity?: Severity;
}): void {
// eslint-disable-next-line no-console
console.error(message);

captureMessage(message, severity);
}

0 comments on commit d3b1856

Please sign in to comment.