Build improvements #342
Merged
Build improvements #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
The Texas Tribune no longer serves AMP articles.
Drop AMP support
Update test CSS accordingly
Bump all sass compiling packages
…n5-1.0.2 Bump json5 from 1.0.1 to 1.0.2
Bump svgo from 2.7.0 to 3.0.2
…p-cache-semantics-4.1.1 Bump http-cache-semantics from 4.1.0 to 4.1.1
Update SASS compiling to latest
Take sourcemaps from SASS compile and include them in transform
It seems that with lightningcss, you have to explicitly set the browser targets. The CLI option will look to package.json, but I'm not sure that the JS api does. The assumption here is also that browserslist comes with sass.
This is a good way to debug any style regression this could introduce
LightningCSS doesn't play nicely with node 12. There are a few references to this in this issue: parcel-bundler/lightningcss#438
Lightning CSS ⚡
Add latest queso patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Why are we doing this? How does it help us?
Faster builds, security, smaller CSS output, cleans up tech debt
How should this be manually tested?
npm run test(kicked off in Github actions) should do the trick! I tested this in texastribune repo and did not see any breaking styles.Are there any smells or added technical debt to note?
The implementation of the new inline source maps are a little ick, but after lots of research of how to do that with Lightning CSS and dart-sass, I'm just happy it works.
Research links: