Make cursor: pointer default on all button elements #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Makes
cursor: pointer
default on the<button>
elementWhy are we doing this? How does it help us?
I keep finding new places where I need to add
cursor: pointer
to buttons e.g. tabs and the icon button to ascend/descend in table columns.As it turns out, making all buttons have pointers is a bit of a hot take. There's a thread on the internet where people argue about it, but this line won me over in favor of it:
How should this be manually tested?
Nothing to test really
Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
Nope. I'm going to merge this and just let it hang out until the next release. It'll help with a forthcoming table PR which I'll add after the JS refactor of the directory tables.