Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cursor: pointer default on all button elements #310

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

ashley-hebler
Copy link
Member

What's this PR do?

Makes cursor: pointer default on the <button> element

Why are we doing this? How does it help us?

I keep finding new places where I need to add cursor: pointer to buttons e.g. tabs and the icon button to ascend/descend in table columns.

As it turns out, making all buttons have pointers is a bit of a hot take. There's a thread on the internet where people argue about it, but this line won me over in favor of it:

One of the main tenets of UX is "don't make me think" .... if you don't have a hand pointer over a button then you have to think "is this a button?"

How should this be manually tested?

Nothing to test really

Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?

Nope. I'm going to merge this and just let it hang out until the next release. It'll help with a forthcoming table PR which I'll add after the JS refactor of the directory tables.

@ashley-hebler ashley-hebler merged commit e09d8ca into main Dec 16, 2020
@ashley-hebler ashley-hebler deleted the button-cursor branch December 16, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant