Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for table borders on row and cells #314

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Allow for table borders on row and cells #314

merged 3 commits into from
Dec 21, 2020

Conversation

ashley-hebler
Copy link
Member

What's this PR do?

Right now, the class c-table--bordered applies a row (top/bottom) border, but this changes that to apply both row and cell (left/right) borders.

This also documents the recommended markup for sorted column headers

Classes added (if any)

-.c-table--bordered-rows- For case where you just want row borders

Why are we doing this? How does it help us?

Used for directory

How should this be manually tested?

npm run dev

See: c-table

Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?

I've been sorta walking back on my initial interpretation of what merits a major release. I think instead of anything that introduces a visual change, it should be anything that introduces visual disruption. In this example, this PR will make this c-table--bordered instance suddenly have borders on all sides if versioned up, but I don't consider that to be disruptive or breaking. My intention is to prevent us from just having a ton of major releases that become daunting to update. I think as long as release notes warn about any subtle style changes, that should be an ok safeguard. I updated the contributing guideline to clarify that.

For those ^ reasons, this will be a minor pre-release to be tested out in the directory feature branches we're working on.

TODOs / next steps:

  • your TODO here

@ashley-hebler ashley-hebler merged commit 777f4bf into main Dec 21, 2020
@ashley-hebler ashley-hebler deleted the tables branch March 11, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant