Allow for table borders on row and cells #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Right now, the class
c-table--bordered
applies a row (top/bottom) border, but this changes that to apply both row and cell (left/right) borders.This also documents the recommended markup for sorted column headers
Classes added (if any)
-
.c-table--bordered-rows
- For case where you just want row bordersWhy are we doing this? How does it help us?
Used for directory
How should this be manually tested?
npm run dev
See: c-table
Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
I've been sorta walking back on my initial interpretation of what merits a major release. I think instead of anything that introduces a visual change, it should be anything that introduces visual disruption. In this example, this PR will make this
c-table--bordered
instance suddenly have borders on all sides if versioned up, but I don't consider that to be disruptive or breaking. My intention is to prevent us from just having a ton of major releases that become daunting to update. I think as long as release notes warn about any subtle style changes, that should be an ok safeguard. I updated the contributing guideline to clarify that.For those ^ reasons, this will be a minor pre-release to be tested out in the directory feature branches we're working on.
TODOs / next steps: