Add a task for creating date labels #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds an
npm run datestask, which uses node-canvas to dynamically create branded, published x year images.Assets added
Why are we doing this? How does it help us?
Ultimately, the goal is similar to what the Guardian wrote about here.
We'll house these images in this repo to keep them out of the way in our main repo. Having them also helps them stay versioned along with other design system-related changes. A design change to the labels would merit a new npm release.
How should this be manually tested?
npm installnpm run datesThis should print
✔ Generating date labelsin the terminal and build 1999 - 2021 date labels.Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
After I pre-release this, I'll add a simple script in our main repo to copy these images into our static_root folder. We'll then use thumbor to reference them as overlays.