Add new tabs design #367
Merged
Add new tabs design #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGibson27
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
🚢 ! Thanks a ton for adding this -- I should have saved you the work and done this after the improve-directory launch!
Only thing I noticed was that arrow-keying changes the active tab but not the active class. But, as you said, the implementation will vary, so hardly a big deal.
Queso is so great. I was reminded of its amazingness today while working on live-blog stuff.
|
Oh I'm so glad to hear that. I was wondering how it was handling the live blog design. And thank you for the review. I think it's good for the demo to the desired keyboard behavior so I went ahead and threw some dinosaur, vanilla JS at it to fix that. I'll work on a branch using this in texastribune before I merge and version it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Updates our style base to use the tabs we added for directory
Why are we doing this? How does it help us?
We made the tabs more minimal for directory because it allowed us to squish them down smaller on mobile. @AndrewGibson27 also provided a model for making our tabs accessible, which has been implemented here.
How should this be manually tested?
npm run devSee: /sections/components/c-tabs/
Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?
It does, this will have to be a major release because of the markup changes needed.
TODOs / next steps: