Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base line height on paragraphs to avoid constantly setting #46

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

ashley-hebler
Copy link
Member

What's this PR do?

Classes added (if any)
  • t-space-base
Classes removed (if any)
  • t-space-nospace

Why are we doing this? How does it help us?

This adds text formatting updates in story body and globally.

How should this be manually tested?

yarn dev

See: line-height variables
See: line-height variables

Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?

I'm going to test in the texastribune repo to be sure, but likely does not.

TODOs / next steps:

  • Test 2.1.0-0 in donations (portal)
  • Test 2.1.0-0 in texastribune

@ashley-hebler ashley-hebler merged commit 895e020 into master Aug 7, 2019
@ashley-hebler ashley-hebler deleted the text-formatting branch August 15, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant