Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some form components #47

Merged
merged 11 commits into from
Aug 9, 2019
Merged

Add some form components #47

merged 11 commits into from
Aug 9, 2019

Conversation

AndrewGibson27
Copy link
Contributor

What's this PR do?

  • Adds components for text inputs, checkboxes, mini-form
  • Adds reduced opacity to all buttons in disabled state
Classes added (if any)
  • .c-text-input
  • .c-checkbox
  • .c-mini-form

Why are we doing this? How does it help us?

These are needed for UMP, but they'll come in handy in many other places as well.

How should this be manually tested?

Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?

Nothing breaking. Will create pre-release on master once this is merged.

@ashley-hebler
Copy link
Member

Added some discussion above, but overall these are all in good form.

@ashley-hebler
Copy link
Member

@emilyyount feel free to check @AndrewGibson27 's shiny, new form components as well!

@emilyyount
Copy link

This all looks great! Thank you both!

@AndrewGibson27 AndrewGibson27 merged commit 6a2ed4a into master Aug 9, 2019
@AndrewGibson27 AndrewGibson27 deleted the forms branch August 9, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants