txs restores wrong top line with folded lines #3627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold 13 lines (i.e. they are hidden) as shown here:
Then scroll down (down is the important information here) to line 253 such that this line is at top of the editor:
Close txs (but not the editor) and find their indices in the session file:
Starting txs the editor shows at top line:
But we expect to see line 253 at top.
Txs calculates the position of
FirstLine
before lines are folded. Since 13 lines are hidden by folding, line 253+13=263 moves to top of the editor. S.QDocument::y(…)
used inscrollToFirstLine
, which respects folded and wrapped lines by callingvisualLine
.To fix this the order of position calculation and folding need to be reversed.