image and video resize doesn't seem to be working

[geyang]

Hi @SimeonC,

I just want to check, is the image resizing working? on my pre19, both the image resizing of video and image are not working.

Thanks,
Ge

[SimeonC]

Yea, it's not working for me either, I'll fix this now I'm back from holiday!

[geyang]

Happy holidays! Have fun:)

[SimeonC]

Ok, should be fixed in new pre-release, can you confirm please?

[mgruesbeck]

I found the same issue. Also, when bower install https://github.com/fraywing/textAngular (the pre-release git) the local bower install still stays it's release 1.2.2.

Is that incorrect or am installing the pre-release wrong?

[geyang]

@mgruesbeck You need bower install https://github.com/fraywing/textAngular#master inorder to install the pre-release git.

@SimeonC , I have not tested this one yet since I need to merge my fork with it first. I will get to this tonight!!

[mgruesbeck]

Thanks @episodeyang.

Alright, I updated to pre-release. All textAngular files are loading with no errors but I'm still having resizing issues.

If I click the image and drag the corner it will pass:
<img height:"xxx" width:"xxx" src="image.jpg">

However, if you click the image and use the percentages to resize no percent width are passed. For example if you select 100% on an image the output will be:
<img src="image.jpg">

I'll wait for @episodeyang's results.

[SimeonC]

@mgruesbeck The percentages are aimed at a percentage of the original size of the uploaded image. So 100% is a 1:1 ratio of the image, I copied the logic off of summernote.org.

[geyang]

@SimeonC @mgruesbeck

The resize handle works well in firefox. However, the image popup does not show.

In Chrome, the handle changes all of the images in the editor proportionally simultaneously. The popup shows properly though.

I haven't tested it in other browsers though.

[mgruesbeck]

Thanks guys. From what @episodeyang is saying it sounds like my issue is different.

For example, when clicking 50% I would expect textAngular to pass:
<img style="width:50%" src="image.jpg">.

However, in my case, no percentage is passed and the output is this:
<img src="image.jpg">

I'll update you if I can figure it out.

[SimeonC]

@mgruesbeck Ugh, that was my bad actually - I just checked and what you said is what should be happening and is what happens on my end when I actually try it. Possibly you have angular-sanitize instead of textAngular-sanitize loaded? That would strip out the width regardless.

@episodeyang I see that now, looks like something weird is going on there...

[SimeonC]

OK, try pre-release 21, that should have it fixed.

[geyang]

@SimeonC , it works!

There is just one problem though, it seems rangy crashes a lot. When it crashes, the whole app turn into a text view.

What I have are two svg images that are 900kb each.

Does anyone else experience crash?

[SimeonC]

What's the error? I haven't had that problem yet - also which rangy version?

[geyang]

There is actually no error message. There is a rangy error that shows from time to time however that is not necessarily the cause of the bug.

I think this bug occurs only when the user upload an svg file.

The error message shows with both textAngular-rangy.min.js and rangy-official 1.3.0-alpha.

[SimeonC]

Weird, I'll try look into this and see if I can find what's causing it, if I can replicate it that is!

[SimeonC]

When you say it only occurs when a user uploads an svg file do you mean like this? <img src="http://upload.wikimedia.org/wikipedia/commons/b/bd/Test.svg"/>

I'm having trouble replicating this and might need some help with some extra steps please!

[geyang]

yes! so in chrome, if I click on this svg a lot, it crashes the page.

this however does not occur with the current demo on the website.

On Tue, Jan 13, 2015 at 3:56 PM, Simeon Cheeseman notifications@github.com
wrote:

When you say it only occurs when a user uploads an svg file do you mean
like this?

—
Reply to this email directly or view it on GitHub
#470 (comment)
.