Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitizer wipes new lines before ta-paste making it impossible to replace them with BR tags #686

Closed
let4be opened this issue May 11, 2015 · 2 comments
Closed

sanitizer wipes new lines before ta-paste making it impossible to replace them with BR tags #686

let4be opened this issue May 11, 2015 · 2 comments

Comments

@let4be
Copy link

let4be commented May 11, 2015

https://github.com/fraywing/textAngular/blob/7ee680ddc7d750641daa4f226b94bb73025749da/src/textAngular.js#L1420

sanitizer runs before paste, while should run after
Current behavior makes it totally impossible to replace new lines with BR tags to preserve text formatting when inserting text/plain into text angular

another approach would be to fix sanitizer(preserve space/newline) but this seems to be more complex
@let4be let4be changed the title Text angular sanitizer wipes new lines before paste making it impossible to replace them with BR tags sanitizer wipes new lines before ta-paste making it impossible to replace them with BR tags May 11, 2015
@let4be let4be mentioned this issue May 11, 2015
Closed
@let4be
Copy link
Author

let4be commented May 11, 2015

the fix is in(last published version):
https://github.com/lavab/textAngular/tree/textAngular/fix-ta-paste-sanitizing

@SimeonC
Copy link
Collaborator

SimeonC commented May 24, 2015

OK, yea that makes sense. Not sure why I thought doing it that way was a good idea.

And yea, I think my poor choices of folder names are causing a bit too much confusion.

nickknissen pushed a commit to ordbogen/textAngular that referenced this issue Jul 1, 2015
fix(taPaste): Fix the taPaste order s.t. sanitizer is called after pa…
b3f67a5 
…ste handler.

Fixes textAngular#686

BREAKING CHANGES: This changes the structure of the files - all production files are now in the dist folder, this makes where PR's should be done a little more clear.

If you were referencing the src/*.js files they will need to be updated to dist/*js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimeonC @let4be