Fix build with Qt 6.6. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QSqlDataBase::exec() has had a deprecation note in the documentation for 12 years and the function has been finally marked as such in Qt 6.6. With -Werror enabled, the build fails due to the deprecation warning.
|
:) This is an automatic-completion error. Thanks. |
vishwin
pushed a commit
to vishwin/freebsd-ports
that referenced
this pull request
Nov 3, 2023
This port builds with -Werror, and due to QSqlDataBase::exec() being finally marked as deprecated in Qt 6.6.0 [1], it fails to build due to deprecation warnings. Add upstreamed patch to fix this issue. [2] Port builds perfectly fine with previous versions of Qt, including 5.x, as it took 12 years for the soft deprecation in the API notes [3] to actually take effect. Upstream notes this was an automatic-completion error. [2] While here: clean up USE_QT for both the qt5 and qt6 flavors and remove checks for long unsupported (3+ years) versions of Qt 5.x. [4] [1] https://doc.qt.io/qt-6/qsqldatabase-obsolete.html [2] textbrowser/dooble#199 [3] https://doc.qt.io/qt-5/qsqldatabase.html Approved by: portmgr (blanket) With hat: kde@ [4]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QSqlDataBase::exec() has had a deprecation note in the documentation for 12 years and the function has been finally marked as such in Qt 6.6. With -Werror enabled, the build fails due to the deprecation warning.