Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted mode and CSS attribute parsing #65

Closed
brondsem opened this issue Dec 5, 2018 · 3 comments
Closed

Restricted mode and CSS attribute parsing #65

brondsem opened this issue Dec 5, 2018 · 3 comments

Comments

@brondsem
Copy link

brondsem commented Dec 5, 2018

Since version 2.3.0, style attributes like h2{position:absolute;top:200px}. This is a title started to come through into the output when using textile_restricted. In 2.2.2 and earlier, textile_restricted kept those out.

Is there a way in the latest versions to omit style attributes from being rendered?
@brondsem
Copy link
Author

I ran a git bisect on this and found the regression began in ae31b8a I may work on a pull request to restore the style attribute restrictions, although it looks like it will involve passing the restricted flag into parse_attributes in a lot of places. Any thoughts?

brondsem added a commit to brondsem/python-textile that referenced this issue May 31, 2019
@brondsem
Restore restricted mode affect on inline styles. Fixes textile#65
58f292e
brondsem added a commit to brondsem/python-textile that referenced this issue May 31, 2019
@brondsem
Restore restricted mode effect on inline styles. Fixes textile#65
304d074
@brondsem
Copy link
Author

I've created pull request #67 for this

ikirudennis added a commit that referenced this issue Jun 8, 2019
@ikirudennis
Merge pull request #67 from brondsem/restricted_styles
eea71e3 
Restore restricted mode effect on inline styles.  Fixes #65

Thanks, @brondsem ! And sorry for the delay.
@ikirudennis
Copy link
Member

Fixed by #67. Thanks once more, @brondsem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brondsem @ikirudennis