update deps #25
Merged
update deps #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
This was referenced Oct 26, 2021
merlinran
reviewed
Oct 27, 2021
peer/mdns/mdns.go
Outdated
| @@ -17,14 +16,7 @@ const connTimeout = time.Second * 10 | |||
|
|
|||
| // Start the MDNS discovery. | |||
| func Start(ctx context.Context, host host.Host, intervalSecs int) error { | |||
There was a problem hiding this comment.
Why leave intervalSecs here? Some compatibility concerns?
There was a problem hiding this comment.
I'll remove and bubble up the changes to dependencies that call this method (dunno yet, but I'll discover when switching to latest tag).
cc @sanderpick about this change since not sure yet is MDNS is much relevant really; but prefer to get your eyes.
merlinran
approved these changes
Oct 27, 2021
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ignacio Hagopian jsign.uy@gmail.com