This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
More consistent use of block.ignore
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
carsonfarmer
requested review from
andrewxhill,
asutula and
sanderpick
as code owners
|
Worth a review and opinion @andrewxhill. I've renamed one endpoint to match others in the lib, but maybe less consistent with other clients now? Can revert specific changes to match. |
|
Quick you take a quick look at this @andrewxhill? |
balupton
approved these changes
Jun 20, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carson Farmer carson.farmer@gmail.com
This also renames it from
removetoignorewhich is more in line with other APIs and more accurate in terms of what is actually happening (UIs can still call it deleting or whatever).