This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
support TextDecoder in older nodejs env #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectdotz
requested review from
andrewxhill,
asutula,
carsonfarmer and
sanderpick
as code owners
Signed-off-by: vsun <vsun@connectdotz.com>
Date: Sat May 25 16:15:31 2019 -0400
On branch TextDecoder-compatibility
Your branch is up-to-date with 'origin/TextDecoder-compatibility'.
Changes to be committed:
new file: src/helpers/__test__/handlers.test.ts
modified: src/helpers/handlers.ts
fixing textileio#118
added a simple check for global TextDecoder, if not available, fallback to node 'util' package.
connectdotz
force-pushed
the
TextDecoder-compatibility
branch
from
0c86f3f
to
0a8c7dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #118
tested it with both node 10.15.1 and 12.3.1
p.s. this is my first contribution to your wonderful work, please let me know if I missed anything.