file: fix CORS on File.prototype.content #124
Conversation
balupton
requested review from
andrewxhill,
asutula,
carsonfarmer and
sanderpick
as code owners
/ref https://textile-public.slack.com/archives/CCRJZJT26/p1560800318046700 Signed-off-by: Benjamin Lupton <b@lupton.cc>
balupton
force-pushed
the
benjamin/fix-cors-content
branch
from
8f5defd
to
7a4db48
Compare
| @@ -15,7 +15,7 @@ export default class File extends API { | |||
| * @returns Raw data | |||
| */ | |||
| async content(hash: string) { | |||
| const response = await this.sendGet(`file/${hash}/data`) | |||
| const response = await this.sendGet(`file/${hash}/content`) | |||
There was a problem hiding this comment.
Nice and easy. @balupton, this is going to come up with other redirects, which I like having available, as it means we can be a little more flexible with releasing updates to js-http-client. Any idea what the best way is to more permanently fix these CORS stoppers on the Go side of things?
There was a problem hiding this comment.
I'm not sure, as any redirect is a mark of deprecation, so we should coordinate immediate parch releases of this api client whenever we do such things with go-tectile. Patch releases will be adopted automatically by consumers of this client. This client is also the only one affected by cors.
|
I'm going to just get this one merged @balupton. I think if I don't squash, you'll get the credit... |
Squashing co-authors the commit, which is fine and dandy. |
Fixes #123
/ref https://textile-public.slack.com/archives/CCRJZJT26/p1560800318046700