Rename Groups not completing successfully

[andrewxhill]

Seeing some issues with this in the current Beta release.

#1084

1. I went to change the name the first time. Edited the name and clicked 'Rename'. Nothing happened, it just stayed on the rename interface.
2. Clicked 'Cancel', as that was the only option left, and it wasn't renamed
3. Hard-killed and went back to group. Went to rename interface. Now, if I edit the name, the 'Rename' option never become clickable so I can only 'Cancel'. Group is still the original name from before step 1.

[undercase]

I'll fix this today-pretty sure I made a small mistake when I was refactoring a function name for the linter.

[asutula]

I've seen this as well. It does work sometimes, though. @undercase are you displaying an error on that rename modal if an error happens?

[undercase]

I knew I was forgetting something-right now it doesn't do anything w/ the error message if there is one, but the error in the redux state blocks you from renaming it again. Will fix it today after I finish the direct message PR.

[asutula]

Yea makes sense. Will be interesting to see what this error is that sometimes happens when renaming.

[andrewxhill]

[sanderpick]

I believe you'll get that error if you're not the thread initiator

[undercase]

I assumed anyone could rename the thread. I'll fix this by not showing the rename group button if the user isn't the initiator.

[andrewxhill]

same, i was under the impression that this was a local change only, not something that would be distributed to other thread members

[undercase]

I figured it was like messenger groups, in that anyone can rename it and it is distributed to everyone else in the group. Looks like it is distributed to everyone else in the group, but only the initiator can change it. Easy to fix, will have a PR for it today.

[asutula]

I mean, the behavior we thought should be there is what should be there. Maybe we should just have go-textile apply some logical permissions to editing the thread name based on the thread permissions?

[sanderpick]

No problem, @undercase - I would have mentioned had I been paying attention. The current behavior is documented in the go doc: https://github.com/textileio/go-textile/blob/master/core/threads.go#L257

[andrewxhill]

good to close this now right @undercase ?

[undercase]

Yep.