IPFS Gateway #198
Merged
IPFS Gateway #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
commented
May 9, 2020
| @@ -0,0 +1,271 @@ | |||
| package gateway | |||
There was a problem hiding this comment.
All the gateway bucket stuff was moved here.
| @@ -0,0 +1,211 @@ | |||
| package gateway | |||
There was a problem hiding this comment.
All the IPFS related gateway stuff is here.
| // if object turns out to be a valid CID, | ||
| // ensure text representation used in subdomain is CIDv1 in Base32 | ||
| // https://github.com/ipfs/in-web-browsers/issues/89 | ||
| rootID, err = cid.NewCidV1(multicodec, rootCid.Hash()).StringOfBase(mbase.Base32) |
There was a problem hiding this comment.
Old style cids are case-sensitive. So, they get converted to base32.
| // We ease the transition by fixing multicodec on the fly: | ||
| // https://github.com/ipfs/go-ipfs/issues/5287#issuecomment-492163929 | ||
| if isPeerIDNamespace(ns) && multicodec != cid.Libp2pKey { | ||
| multicodec = cid.Libp2pKey |
There was a problem hiding this comment.
Now we have these key type cids. Everything is a cid now.
| @@ -1,6 +1,6 @@ | |||
| {{template "header" "Bucket"}} | |||
There was a problem hiding this comment.
This template is now used for normal IPFS dirs and bucket dirs.
| @@ -0,0 +1,82 @@ | |||
| package gateway | |||
There was a problem hiding this comment.
Nothing new here, just moving this thread gateway stuff to its own file.
| m.ctxsLock.Lock() | ||
| m.ctxs[keyID] = cancel | ||
| m.ctxsLock.Unlock() | ||
| if err := m.publishUnsafe(pctx, pth, keyID); err != nil { | ||
| if !errors.Is(err, context.Canceled) { | ||
| // Logging as a warning because this often fails with "context deadline exceeded", | ||
| // even if the entry can be found on the network (not fully saturated). | ||
| // The publish deadline seems to be fixed at one minute. ¯\_(ツ)_/¯ |
There was a problem hiding this comment.
They fixed it: ipfs/kubo#7256. Now we can use a longer timeout since these are just spinning on their own anyway.
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
/ipfs,/ipns,/p2p,/ipldnamespaces in the gatewaygo-ipfsgo-ipfstov0.5.1, which includes a fix for the hard-coded max timeout when publishing