add default values

textkernel · Mar 24, 2020 · bdfde31 · bdfde31
1 parent d67a405
commit bdfde31
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/src/components/Select/SuggestionsList/SuggestionsList.tsx b/src/components/Select/SuggestionsList/SuggestionsList.tsx
@@ -81,6 +81,7 @@ export function SuggestionsList<S>(props: Props<S>) {
 
 SuggestionsList.defaultProps = {
     useOptimizeRender: false,
+    inputValue: '',
 };
 
 SuggestionsList.displayName = 'SuggestionsList';
diff --git a/src/components/Select/SuggestionsList/__tests__/__snapshots__/SuggestionsList.spec.js.snap b/src/components/Select/SuggestionsList/__tests__/__snapshots__/SuggestionsList.spec.js.snap
@@ -119,6 +119,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
     }
   }
   highlightedIndex={1}
+  inputValue=""
   noSuggestionsPlaceholder="noSuggestionsPlaceholder"
   suggestionToString={[Function]}
   suggestions={
@@ -173,6 +174,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -206,6 +208,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -239,6 +242,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -272,6 +276,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -305,6 +310,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -338,6 +344,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -371,6 +378,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -404,6 +412,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -437,6 +446,7 @@ exports[`SuggestionsList should initially render component correctly 1`] = `
         <MarkedText
           inline={true}
           key=".0"
+          marker=""
         >
           <Text
             context="default"
@@ -573,6 +583,7 @@ exports[`SuggestionsList should render optimization list correctly 1`] = `
     }
   }
   highlightedIndex={1}
+  inputValue=""
   noSuggestionsPlaceholder="noSuggestionsPlaceholder"
   suggestionToString={[Function]}
   suggestions={

diff --git a/src/components/TwoPaneView/TwoPaneView.tsx b/src/components/TwoPaneView/TwoPaneView.tsx
@@ -53,8 +53,8 @@ export const TwoPaneView: React.FC<Props> = props => {
 
         const { width: fullWidth } = blockEl.getBoundingClientRect();
         const blockStyle = window.getComputedStyle(blockEl, null);
-        const paddingRight = parseInt(blockStyle.getPropertyValue('padding-right'), 10);
-        const paddingLeft = parseInt(blockStyle.getPropertyValue('padding-left'), 10);
+        const paddingRight = parseInt(blockStyle.getPropertyValue('padding-right'), 10) || 0;
+        const paddingLeft = parseInt(blockStyle.getPropertyValue('padding-left'), 10) || 0;
 
         const leftEl = leftRef.current;
         if (!leftEl) return;

diff --git a/src/components/TwoPaneView/__tests__/__snapshots__/TwoPaneView.spec.js.snap b/src/components/TwoPaneView/__tests__/__snapshots__/TwoPaneView.spec.js.snap
@@ -25,7 +25,7 @@ exports[`<TwoPaneView> that renders a two pane view should render correctly 1`]
             "display": "none",
             "height": 0,
             "top": -0,
-            "width": NaN,
+            "width": 0,
           }
         }
       >
@@ -36,7 +36,7 @@ exports[`<TwoPaneView> that renders a two pane view should render correctly 1`]
               "display": "none",
               "height": 0,
               "top": -0,
-              "width": NaN,
+              "width": 0,
             }
           }
         >