fix linting

textkernel · Aug 30, 2019 · d1e3a23 · d1e3a23
1 parent a1d8745
commit d1e3a23
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/src/components/TwoPaneView/TwoPaneView.js b/src/components/TwoPaneView/TwoPaneView.js
@@ -23,16 +23,6 @@ const TwoPaneView = props => {
     const leftRef = React.createRef();
     const blockRef = React.createRef();
 
-    React.useLayoutEffect(() => {
-        window.addEventListener('scroll', handleScroll);
-        return () => window.removeEventListener('scroll', handleScroll);
-    });
-
-    React.useLayoutEffect(() => {
-        window.addEventListener('resize', handleResize);
-        return () => window.removeEventListener('resize', handleResize);
-    });
-
     const handleScroll = (e, leftEl = leftRef.current) => {
         const leftDimensions = leftEl.getBoundingClientRect();
         const top = leftDimensions.top > 0 ? 0 : -leftDimensions.top;
@@ -62,6 +52,16 @@ const TwoPaneView = props => {
         handleScroll(e, leftEl);
     };
 
+    React.useLayoutEffect(() => {
+        window.addEventListener('scroll', handleScroll);
+        return () => window.removeEventListener('scroll', handleScroll);
+    });
+
+    React.useLayoutEffect(() => {
+        window.addEventListener('resize', handleResize);
+        return () => window.removeEventListener('resize', handleResize);
+    });
+
     return (
         <BlockWidthRestrictor {...rest} ref={blockRef} {...block(props)}>
             {React.Children.map(children, child => {
@@ -106,4 +106,8 @@ TwoPaneView.propTypes = {
     },
 };
 
+TwoPaneView.defaultProps = {
+    children: null,
+};
+
 export default TwoPaneView;