Not all tests in textlint have been run

[takmatsukawa]

What version of textlint are you using?

4251c9e

What file type (Markdown, plain text, etc.) are you using?

What did you do? Please include the actual source code causing the issue.

I followed the Development Workflow
, added a new test in config-initializer-test.ts and npm run test in packages/textlint.

What did you expect to happen?

What actually happened? Please include the actual, raw output from textlint.

The test I added never failed.

I found mocha's .only() is used here. According to mocha's doc, It forces only its specified tests to be executed.
After removing the .only, some tests failed.

[azu]

Ah, It .only should beremoved.

[azu]

It related with Dynamic Import + .ts

Dynamic import can not import .ts file by default.
Probably, loader: ts-node/esm is required.

[azu]

We need to add https://github.com/lo1tuma/eslint-plugin-mocha for preventing this issue.

• maybe related ESLint for TypeScript #685

[azu]

• Fixed in test(textlint): remove it.only and use ts-node/esm  #1043
• Follow up: Use "ts-node" filed instead of "ts-node-test-register" #1044

[takmatsukawa]

Good work! Additionally, we can use mocha --forbid-only option.

Be mindful not to commit usages of .only() to version control, unless you really mean it! To do so one can run mocha with the option --forbid-only in the continuous integration test command (or in a git precommit hook).

The option will make the executions of tests containing .only fail.

[azu]

It may difficutlt to use --forbid-only.
We want to only use --forbid-only on CI.

if process.env.CI 
  mocha --forbid-only 
else 
  mocha

.mocharrc.js will resolve it, but I not want to use dynamic config.
(It make migration difficult)

I want to write like this.

MOCHA_FORBIT_ONLY=1 mocha

Howevert, mocha --forbid-only is not bad at start point.

• Related: Use "ts-node" filed instead of "ts-node-test-register" #1044

[azu]

• Make --forbid-only (but not --forbid-pending) default mochajs/mocha#3030

[takmatsukawa]

I found an example like this:

.mocharc.js

'use strict';

module.exports = {
  'forbid-only': Boolean(process.env.CI)
};

I'm not sure if it works in this repo.

[azu]

.mocharrc.js will resolve it, but I not want to use dynamic config.
(It make migration difficult)