New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit mocha setup #451
Labels
Type: Testing
Adding missing tests or correcting existing tests
Comments
ts-jest has same problem 😢 |
I've created a loader package that use with We can replace |
@azu, thanks for the new module. I'll try. |
0x6b
added a commit
to 0x6b/textlint
that referenced
this issue
Jan 28, 2018
In order to improve credibility and stability of tests, use `ts-node-test-register` to: - Load `tsconfig.json` from `test` directory - Enforce `typeCheck` always replacing `ts-setup.js` with `ts-node-test-register` in following packages: - `textlint-tester` - `ast-node-types` - `ast-traverse` - `fixer-formatter` - `kernel` - `linter-formatter` - `textlint` https://www.npmjs.com/package/ts-node-test-register Closes textlint#451.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We found that, in some situation,
mocha
runs fine whiletsc
cannot compile TypeScript test cases (issue #448 and pull request #449). We have to review current setup for each packages and make changes needed in order to improve credibility/stability of tests.packages/@textlint/ast-node-types/test/ts-setup.js
packages/@textlint/ast-traverse/test/ts-setup.js
packages/@textlint/fixer-formatter/test/ts-setup.js
packages/@textlint/kernel/test/ts-setup.js
packages/@textlint/linter-formatter/test/ts-setup.js
packages/textlint-tester/test/ts-setup.js
packages/textlint/test/ts-setup.js
As @azu said at #449 (comment), Jest is one of options.
Edit: add list of
ts-setup.js
for review.Edit 2: update list as some packages are moved to
@textlint
by #455The text was updated successfully, but these errors were encountered: