Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve contribution guideline #472

Open
0x6b opened this issue Jan 15, 2018 · 2 comments
Open

docs: improve contribution guideline #472

0x6b opened this issue Jan 15, 2018 · 2 comments
Assignees
Labels
Type: Documentation Documentation only changes

Comments

@0x6b
Copy link
Member

0x6b commented Jan 15, 2018

As part of recent documentation enhancement efforts (#434, #466, #468, #470, #471), I would like to improve contribution guideline, mainly try to document my understanding from trial–and–error and great assistance from @azu. I'd like to hear from folks around here before putting any effort into these changes as it will take some time to write.

My proposals are:

  1. Merge part of README and Contributing Guideline
  2. Split into main document How to Contribute and supporting documents Coding Guidelines + Code Organization
  3. Add these three to Contributing section of the side bar at new documentation site
  4. Simplify README

New documents could (but not limited to) have following TOCs. Appreciate any comments. Thanks!


How to Contribute

Reporting New Issues or Feature Suggestions

Create an issue first

  • Modify Existing Document
  • Add New Document
  • Fix Known Issues or Implement New Feature
    • Good First Issue

Development Workflow

Installing Prerequisites

  • Git
  • Node.js 4.0.0+
  • npm 2.0.0+
  • yarn 1.3.2+

Cloning Copy of textlint

  • Folk textlint repo

  • Clone locally

      git clone ...
    

Creating Branch for Your Work

git checkout -b ...

Building Codebase

yarn
yarn bootstrap
yarn build
yarn build:website

Making Changes

Don't forget to add a test and document!

Running Tests

  • For Code Changes:
    • While Developing
      • Package Level Test
    • Before Push
      • Unit Test
      • Examples Test
      • Integration Test
      • All
  • For Documentation Changes:
    • While Developing and Before Push
      • Documentation Test

Committing the Changes

Pushing the Commit and Opening a Pull Request

Working with Reviews (if any)

  • Push additional commits
  • Pull upstream
  • Rebase

Merge!


Coding Guidelines

Code Linting

Style

Commit Message Format

Semantic Versioning


Code Organization

textlint architecture

kernel/rule/filter/preset/plugin/formatter/fixer/etc... (will need help from @azu)

Monorepo with Lerna

Core Packages

Rule and Plugin Helpers

Related GitHub Organizations and Repositories

@0x6b 0x6b added the Type: Documentation Documentation only changes label Jan 15, 2018
@0x6b 0x6b self-assigned this Jan 15, 2018
@azu
Copy link
Member

azu commented Jan 17, 2018

Thanks for nice proposal.
It looks good for me.

📝 memo
textlint has long long README.
It is expected result.( It is inspired by power-assert.)

Because, almost user does’t look into link.
Flat README is useful for describing the overview.
But, we will get documet site in recenty.
Reafactoring existing documents is reasonable.

@0x6b
Copy link
Member Author

0x6b commented Jan 17, 2018

@azu, thank you. I will work on this.

I think documents need some redundancy/repetition to clearly deliver message to users so long README is ok for me as well. Let me try.

0x6b added a commit to 0x6b/textlint that referenced this issue Jan 27, 2018
As a first step of textlint#472, improve contribution guideline.
0x6b added a commit to 0x6b/textlint that referenced this issue Jan 27, 2018
As a first step of textlint#472, improve contribution guideline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes
Projects
None yet
Development

No branches or pull requests

2 participants