Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix files field #782

Closed
azu opened this issue May 23, 2021 · 1 comment · Fixed by #787
Closed

Fix files field #782

azu opened this issue May 23, 2021 · 1 comment · Fixed by #787
Labels
good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request

Comments

@azu
Copy link
Member

azu commented May 23, 2021 •
edited
Loading

Current

  "files": [
            "bin/",
            "lib/",
            "module/",
            "src/"
   ],

it should be

  "files": [
            "bin/",
            "lib/",
            "module/",
            "src/",
+           "!*.tsbuildinfo"
   ],

Currently, tsbuildinfo file is included in the distributions files.
We do not want to includes it.

📝 tsbuildinfo is TypeScript build cache.

Check

You can check the included files via npm pack command.

npm pack
@azu azu changed the title Fix files filed Fix files field May 23, 2021
@azu azu added the good first issue Good for newcomers label May 23, 2021
@azu

This comment has been minimized.

Sign in to view
@azu azu added the Status: PR Welcome Welcome to Pull Request label May 23, 2021
@rbrishabh rbrishabh mentioned this issue May 23, 2021
Merged
@azu azu closed this as completed in #787 May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Remove tsbuildinfo from distributions files rbrishabh/textlint
1 participant
@azu