Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kernel): remove node:events #1003

Merged
merged 5 commits into from Jan 22, 2023
Merged

refactor(kernel): remove node:events #1003

merged 5 commits into from Jan 22, 2023

Conversation

azu
Copy link
Member

@azu azu commented Jan 22, 2023 •
edited

fix #996
fix #730

@azu azu linked an issue Jan 22, 2023 that may be closed by this pull request
Remove events modules from @textlint/kernel #996
Closed
azu
azu commented Jan 22, 2023
View reviewed changes
packages/@textlint/kernel/src/util/timing.ts
fn.apply(null, Array.prototype.slice.call(arguments));
await fn(...args);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may fix #730

@azu azu merged commit cfb56da into master Jan 22, 2023
@azu azu deleted the feature/996 branch January 22, 2023 01:28
@azu azu added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Jan 25, 2023
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove events modules from @textlint/kernel TIMING=1 does not work correctly
1 participant
@azu