New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(textlint): export as ES module #344

Merged
merged 3 commits into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@Leko
Member

Leko commented Nov 27, 2017

This PR closes #337

Additional changes

  • Fixed FIXME comment because test passed even if remove constant types.
  • Update Use as module documentation

Leko added some commits Nov 27, 2017

refactor(textlint): export as ES module
Use export instead of module.exports
Closes #337
docs(textlint): update level of abstraction
Followed change of index.ts

@azu azu referenced this pull request Nov 27, 2017

Closed

textlint@10.0.0 #346

@azu

azu approved these changes Nov 27, 2017

LGTM

TextLintCore,
// Constant Types
TextLintMessageType: MessageType,
TextLintMessageSeverityLevel: SeverityLevel,

This comment has been minimized.

@azu

azu Nov 27, 2017

Member
// Core API for linting a **single** text or file.
TextLintCore,
// Constant Types
TextLintMessageType: MessageType,

This comment has been minimized.

@azu

azu Nov 27, 2017

Member
// Constant Types
TextLintMessageType: MessageType,
TextLintMessageSeverityLevel: SeverityLevel,
TextLintNodeType

This comment has been minimized.

@azu

azu Nov 27, 2017

Member

Some user.
But it is for testing.

The user can use @textlint/ast-node-types insteadof it.

@azu

azu Nov 27, 2017

Member

Some user.
But it is for testing.

The user can use @textlint/ast-node-types insteadof it.

This comment has been minimized.

@azu

azu Nov 27, 2017

Member

I've filed related issues and note it as BREAKING CHANGE.
textlint/textlint-filter-rule-whitelist#1
textlint/textlint-rule-report-node-types#2
textlint/textlint-filter-rule-node-types#9

📝 textlint 10.0.0 notes

@azu

azu Nov 27, 2017

Member

I've filed related issues and note it as BREAKING CHANGE.
textlint/textlint-filter-rule-whitelist#1
textlint/textlint-rule-report-node-types#2
textlint/textlint-filter-rule-node-types#9

📝 textlint 10.0.0 notes

@azu azu merged commit cacbd64 into textlint:master Nov 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@azu

This comment has been minimized.

Show comment
Hide comment
@azu

azu Nov 27, 2017

Member

@Leko Thanks for work!

Member

azu commented Nov 27, 2017

@Leko Thanks for work!

@Leko Leko deleted the Leko:commonjs_to_esmodule branch Nov 28, 2017

@azu azu referenced this pull request Dec 28, 2017

Open

kernel: export SeverityLevelTypes #427

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment