refactor(textlint): export as ES module #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
azu
approved these changes
Nov 27, 2017
| TextLintCore, | ||
| // Constant Types | ||
| TextLintMessageType: MessageType, | ||
| TextLintMessageSeverityLevel: SeverityLevel, |
There was a problem hiding this comment.
No user.
Can be removed.
| // Core API for linting a **single** text or file. | ||
| TextLintCore, | ||
| // Constant Types | ||
| TextLintMessageType: MessageType, |
There was a problem hiding this comment.
No user.
Can be removed
| // Constant Types | ||
| TextLintMessageType: MessageType, | ||
| TextLintMessageSeverityLevel: SeverityLevel, | ||
| TextLintNodeType |
There was a problem hiding this comment.
Some user.
But it is for testing.
The user can use @textlint/ast-node-types insteadof it.
There was a problem hiding this comment.
I've filed related issues and note it as BREAKING CHANGE.
textlint/textlint-filter-rule-allowlist#1
textlint/textlint-rule-report-node-types#2
textlint/textlint-filter-rule-node-types#9
📝 textlint 10.0.0 notes
This was referenced Nov 27, 2017
|
@Leko Thanks for work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #337
Additional changes
FIXMEcomment because test passed even if remove constant types.