fix(textlint-formatter): run all tests #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct mocha test glob pattern to run all tests. Closes textlint#402.
azu
reviewed
Dec 19, 2017
| @@ -16,7 +16,7 @@ | |||
| "bin/" | |||
| ], | |||
| "scripts": { | |||
| "test": "mocha test/*.js" | |||
| "test": "mocha test/**/*.js" | |||
There was a problem hiding this comment.
Can you try --no-color option?
There was a problem hiding this comment.
Run test from top directory without --no-color have passed successfully.
There was a problem hiding this comment.
Should I add --no-color option to the package.json, or leave it as it is (at this moment, and fix test cases later)?
There was a problem hiding this comment.
Please add --no-color option.
master branch should be always passed tests in any environment.
Disable colors in order to get consistent test result.
|
Thank you! |
This was referenced Dec 23, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct mocha test glob pattern to run all tests. Closes #402.