Use enumeration for OakPerformTableViewAction… return values

textmate · Apr 23, 2021 · 984f59b · 984f59b
1 parent 05e4127
commit 984f59b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/Frameworks/OakAppKit/src/OakAppKit.h b/Frameworks/OakAppKit/src/OakAppKit.h
@@ -3,10 +3,12 @@ extern NSNotificationName const OakCursorDidHideNotification;
 
 BOOL OakIsAlternateKeyOrMouseEvent (NSUInteger flags = NSEventModifierFlagOption, NSEvent* anEvent = [NSApp currentEvent]);
 
-extern NSUInteger const OakMoveMoveReturn;
-extern NSUInteger const OakMoveAcceptReturn;
-extern NSUInteger const OakMoveCancelReturn;
-extern NSUInteger const OakMoveNoActionReturn;
+typedef NS_ENUM(NSUInteger, OakPerformTableViewActionResult) {
+	OakMoveMoveReturn,
+	OakMoveAcceptReturn,
+	OakMoveCancelReturn,
+	OakMoveNoActionReturn,
+};
 
 NSUInteger OakPerformTableViewActionFromKeyEvent (NSTableView* tableView, NSEvent* event);
 NSUInteger OakPerformTableViewActionFromSelector (NSTableView* tableView, SEL selector);
diff --git a/Frameworks/OakAppKit/src/OakAppKit.mm b/Frameworks/OakAppKit/src/OakAppKit.mm
@@ -34,11 +34,6 @@ BOOL OakIsAlternateKeyOrMouseEvent (NSUInteger flags, NSEvent* anEvent)
 
 static NSString* const kUserDefaultsEnableLoopFilterList = @"enableLoopFilterList";
 
-NSUInteger const OakMoveMoveReturn     = 0;
-NSUInteger const OakMoveAcceptReturn   = 1;
-NSUInteger const OakMoveCancelReturn   = 2;
-NSUInteger const OakMoveNoActionReturn = 3;
-
 @interface OakTableViewActionHelper : NSResponder
 @property (nonatomic) NSTableView* tableView;
 @property (nonatomic) NSUInteger returnCode;