Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure with OS X 10.11 SDK from Xcode 7.0–7.2.1 #1402

Merged
merged 1 commit into from Feb 6, 2018

Conversation

ryandesign
Copy link
Contributor

Building textmate 2.0-rc.4 on OS X 10.10 with Xcode 7.2.1 (the last version that works on OS X 10.10) with the 10.11 SDK, the build fails:

Frameworks/OakCommand/src/OakCommand.mm:182:1: error: ARC forbids synthesizing a property of an Objective-C object with unspecified ownership or storage attribute
@implementation OakCommand
^
Frameworks/OakCommand/src/OakCommand.h:16:29: note: property declared here
@property (nonatomic) void(^modalEventLoopRunner)(OakCommand*, BOOL* didTerminate);
                            ^
Frameworks/OakCommand/src/OakCommand.mm:182:1: error: ARC forbids synthesizing a property of an Objective-C object with unspecified ownership or storage attribute
@implementation OakCommand
^
Frameworks/OakCommand/src/OakCommand.h:17:29: note: property declared here
@property (nonatomic) void(^terminationHandler)(OakCommand*, BOOL normalExit);
                            ^
2 errors generated.
Frameworks/DocumentWindow/src/SelectGrammarViewController.mm:39:1: error: ARC forbids synthesizing a property of an Objective-C object with unspecified ownership or storage attribute
@implementation SelectGrammarViewController
^
Frameworks/DocumentWindow/src/SelectGrammarViewController.mm:24:29: note: property declared here
@property (nonatomic) void(^callback)(SelectGrammarResponse, BundleGrammar*);
                            ^
1 error generated.

From my brief investigation, it seems that Xcode 7.3's 10.11 SDK (version 10.11.4) will consider these properties to be strong by default, but with Xcode 7.2.1 (10.11 SDK version 10.11.2) and earlier, it has to be specified explicitly.

Versions of the OS X 10.11 SDK prior to 10.11.4 require this to
be done explicitly. This fixes the build on OS X 10.10 when
using the OS X 10.11 SDK from Xcode 7.2.1 and earlier.
@sorbits sorbits merged commit bade405 into textmate:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants