Extend support for theming the gutter #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New theme setting: gutterSelectionBackground
|
Pulled, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New theme setting: gutterSelectionBackground
Shadows the changes made for the initial gutter view theming.
Ideally would also add in gutterSelectionForeground colour to allow colour theming of the selected line numbers text too, but this seems to be a bit more complicated to implement (at the [GutterView drawRect] level), so leaving for now!
Note: this code also changes the default gutter selection color from the previous change. It now defaults to "softened" version of the background colour, rather than the selection colour.