Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron out source structure #4

Open
gocom opened this issue Jul 5, 2013 · 5 comments
Open

Iron out source structure #4

gocom opened this issue Jul 5, 2013 · 5 comments

Comments

@gocom
Copy link
Contributor

gocom commented Jul 5, 2013

To make build tasks more functional. Main purpose is to clearly separate design documents and allow building without having to specify individual files and directories.

@ghost ghost assigned gocom Jul 5, 2013
@philwareham
Copy link
Member

Is the watch folder for Compass set right? Currently it's...

files: 'src/sass/**',

Shouldn't it be...

files: 'src/assets/sass/**',

If so, it also needs changing in the Textpattern.com repo too. Might explain why I've never had grunt watch working on this project.

@gocom
Copy link
Contributor Author

gocom commented Nov 14, 2013

Watching was broken in 5bf416e, it did use to work before.

Yes, there should be assets in the path. I've added it.

@philwareham
Copy link
Member

I assume maybe the same is also true for the grunt jshint?...

files: ['Gruntfile.js', 'src/js/*.js'],

Should be...

files: ['Gruntfile.js', 'src/assets/js/*.js'],

Although by changing that the project won't build as jshint flags things up in the main.js file. Again this is also true of the Textpattern.com project (because I duplicated this code to there).

@gocom
Copy link
Contributor Author

gocom commented Nov 14, 2013

Yes, it should check the actual source file. It flagging the file isn't reason to not to fix it. It means the JavaScript is wrong and it should be corrected.

@gocom
Copy link
Contributor Author

gocom commented Nov 14, 2013

It now lints the JavaScript files and linting passes just fine; there are no syntax issues in main.js I would have to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants