Ignore all and splity by all whitespace characters where expected #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method syllable_count used split(' ') and not split()
and thus didn't split by newline characters.
The methods char_count and letter_count didn't substitute newlines. Now
a regex for all whitespace characters is used.
changes to char_count, letter_count, and syllable_count mean some tests are failing
|
@LKirst, thank you for this. I've pushed some changes to the tests as this change changes some results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method syllable_count used split(' ') and not split()
and thus didn't split by newline characters.
The methods char_count and letter_count didn't substitute newlines. Now
a regex for all whitespace characters is used.
Fix #158