Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function and added extra test #163

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Fixed function and added extra test #163

merged 2 commits into from
Aug 13, 2021

Conversation

Clickedbigfoot
Copy link
Contributor

No description provided.

@Clickedbigfoot Clickedbigfoot mentioned this pull request Aug 12, 2021
Closed
@alxwrd
Copy link
Member

alxwrd commented Aug 13, 2021

Hi @Clickedbigfoot, thank you!

I've pushed a commit to move the set_lang to within the test, as I think that was the underlying issue (the test that ran before it was setting the language to Spanish). It might be jarring if the library suddenly switches languages, even if that's what the user probably intends.

@alxwrd alxwrd merged commit 7c8a8cb into textstat:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxwrd alxwrd alxwrd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Clickedbigfoot @alxwrd