Added threshold for calc of difficult words #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @bradfordlynch 👋 ! Thank you for your contribution. I've opened a seperate issue (#73) to have a look into the other uses of This looks spot on, excellent! |
alxwrd
added a commit
that referenced
this pull request
Apr 6, 2019
alxwrd
added a commit
that referenced
this pull request
Apr 9, 2019
alxwrd
added a commit
that referenced
this pull request
Apr 9, 2019
* update travis file * ignore pipfile.lock * add pipfile for pipenv support * fix style issues * revert text_standard test case * update gunning_fog test from #71 * update lexicon_count test closes #50. just allow `remove_punc` to remove '&' symbols * add build badge * style clean up * remove requires from pipfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in Issue 70 the calculation of Gunning Fog is using the wrong threshold. Since the difficult_words method is used in various places, I added a default value for syllable_threshold which preserves the original behavior for the other methods but allows the Gunning Fog calculation to be corrected.