Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubwidgetContainer Inherit Font #208

Merged
merged 1 commit into from Sep 1, 2023

Conversation

CasualYT31
Copy link
Contributor

Previously, a TabContainer would not pass on its font to its internal Container. This would mean that it would be stuck using the default font unless it was set manually.

Now, TabContainer overrides rendererChanged(), and sets its Container's inherited font to the TabContainer's font once it is notified that its font has changed.

I noticed the same problem was also present for the SpinControl, so now its font is passed on to its EditBox, too.

I am not too sure if more properties should be handled in these methods. If you can think of any more let me know and I can add them.

@texus
Copy link
Owner

texus commented Aug 31, 2023

Could this perhaps be solved in SubWidgetContainer, i.e. by overriding rendererChanged there and passing the font to m_container so that no code needs to be changed in TabContainer and SpinControl?

@CasualYT31
Copy link
Contributor Author

Good point, got a bit ahead of myself. I'll clean the code up.

@CasualYT31 CasualYT31 changed the title Tabcontainer inherit font SubwidgetContainer Inherit Font Aug 31, 2023
@texus texus merged commit 23e4477 into texus:1.x Sep 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants