-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt ghostnet constats + deprecate -R --release-override #661
Conversation
jdsika
commented
Mar 27, 2023
•
edited
edited
- updated the ghostnet constants
- removed -R argument
- introduced --adjust_early_payouts argument
- still keeping release_override as variable in the code but reduced it to values 0 or -(preserved_cycles+1)
- fixed bug in parser which allowed for invalid arguments
- set sunset to 29.03.2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this on ghostnet with my PR as well (#663) and the software was working as expected. I had to remove -release_override
param, as expected.
These constants are necessary to calculate estimated rewards.
now you are doing it my way @vkresch by just deleting the damn tests ;))) |
@jdsika I deleted the rpc tests in the api consistency test due to the removal of rpc support of trd. |