Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt ghostnet constats + deprecate -R --release-override #661

Merged
merged 16 commits into from
Mar 29, 2023

Conversation

jdsika
Copy link
Contributor

@jdsika jdsika commented Mar 27, 2023

  • updated the ghostnet constants
  • removed -R argument
  • introduced --adjust_early_payouts argument
  • still keeping release_override as variable in the code but reduced it to values 0 or -(preserved_cycles+1)
  • fixed bug in parser which allowed for invalid arguments
  • set sunset to 29.03.2023

@jdsika jdsika added the bug Something isn't working label Mar 27, 2023
@jdsika jdsika added this to the v11.5 (Lima) milestone Mar 27, 2023
@jdsika jdsika changed the title adapt ghostnet constats adapt ghostnet constats + deprecate -R --release-override Mar 28, 2023
@jdsika jdsika requested review from nicolasochem and rvermootenct and removed request for rvermootenct March 28, 2023 14:28
@jdsika jdsika added the enhancement New feature or request label Mar 28, 2023
@jdsika jdsika requested a review from vkresch March 28, 2023 15:08
@jdsika jdsika removed the request for review from vkresch March 28, 2023 18:44
Copy link
Contributor

@nicolasochem nicolasochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on ghostnet with my PR as well (#663) and the software was working as expected. I had to remove -release_override param, as expected.

@jdsika
Copy link
Contributor Author

jdsika commented Mar 29, 2023

now you are doing it my way @vkresch by just deleting the damn tests ;)))

@jdsika jdsika merged commit c55bad4 into master Mar 29, 2023
8 checks passed
@jdsika jdsika deleted the fix/ghostnet-parameter branch March 29, 2023 13:38
@vkresch
Copy link
Contributor

vkresch commented Mar 29, 2023

@jdsika I deleted the rpc tests in the api consistency test due to the removal of rpc support of trd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants