disable RPC after Mumbai #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 problems: * blocks per cycle is changing, so the calculation of cycle beginning, cycle snapshots etc... needs to be adjusted * due to twice more blocks per cycle, the rights query will take even longer, making rpc provider even less appealing as an option Besides, the engineering capacity is limited, and everyone is using TRD with tzkt. Let's disable RPC for now.
|
tzstats is working to my knowledge. Was it disabled before? |
I guess so. I found the code like this :) |
|
Well. I just figured out that the whole thing is not working, great |
|
I am fixing it |
jdsika
approved these changes
Mar 29, 2023
|
There are currently tests which are stuck in an infinite loop on the CI but locally they are fine. I am currently disabling them. Will merge the disabling shortly into master. @nicolasochem thanks for opening the PR. Seems like not activating tzstats is my bad ... I was fixing the parameters only via the tests using tzkt as the standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 problems:
Besides, the engineering capacity is limited, and everyone is using TRD with tzkt. Let's disable RPC for now.
Effort: nicolasochem, 0.5h | jdsika, 0.5h