Port back direct comparison enum and fix API key #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkresch
commented
Nov 6, 2023
| @@ -351,7 +351,7 @@ def validate_rewards_type(self, conf_obj): | |||
| "Defaults to 'actual' rewards payout type.".format(REWARDS_TYPE) | |||
| ) | |||
|
|
|||
| if conf_obj[REWARDS_TYPE].isEstimated(): | |||
| if conf_obj[REWARDS_TYPE] == RewardsType.ESTIMATED: | |||
There was a problem hiding this comment.
This is strange that conf_obj[REWARDS_TYPE] can be a string which needs further investigations why this is happening. For now I just port back as a quick hotfix.
There was a problem hiding this comment.
Can't you test for a string and make a case handling here? Maybe there is no proper cast in die config loader?
jdsika
approved these changes
Nov 6, 2023
|
@vkresch can you please check for a consistent use of the variable name? tzpro_api_key or tz_pro_api_key I think it should be this: tzpro_api_key |
I agree, it matches the domain and the brand. |
|
sure I will update it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #687 and API key naming fix.
Work effort: 0.5h