make tzpro_api_key optional #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most TRD users use tzkt as backend. Right now, we make it mandatory to pass `tzpro_api_key = ''` in the config. I'm introducing a new method to set default attributes in code. In this case, the default tzpro_api_key is `None`. I verified that when using the tzpro provider, the program still fails later when the key is unset: ``` 2024-02-06 15:07:29,721 - MainThread - INFO - Failed to get network configuration constants from a local node (http://127.0.0.1:8732). 2024-02-06 15:07:29,731 - MainThread - INFO - Loading baking configuration file baker_actual_tzkt/cfg/baker.yaml 2024-02-06 15:07:29,737 - MainThread - ERROR - [Process Life Cycle completing With Failure] Error Details: Please set a tzpro api key in the config to use this block api! ``` All previous parameters remain mandatory, for now.
jdsika
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most TRD users use tzkt as backend. Right now, we make it mandatory to pass
tzpro_api_key = ''in the config.I'm introducing a new method to set default attributes in code. In this case, the default tzpro_api_key is
None.I verified that when using the tzpro provider, the program still fails later when the key is unset:
I also verified that tzkt payout works with the param missing from the config.
All previous parameters remain mandatory, for now.
Work effort: 1hr