Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage trait borrow #263

Merged
merged 10 commits into from
Apr 21, 2021
Merged

Storage trait borrow #263

merged 10 commits into from
Apr 21, 2021

Conversation

kkloberdanz
Copy link
Contributor

@kkloberdanz kkloberdanz commented Apr 20, 2021 •
edited

Small change, borrowing keys and values in storage traits instead of moving.
Issue: #262

mortendahl
mortendahl approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mortendahl mortendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mortendahl
Copy link
Member

heads up: don't merge until CI is passing (should be a simple cargo fmt)

@kkloberdanz kkloberdanz merged commit c05000f into main Apr 21, 2021
@kkloberdanz kkloberdanz deleted the storage-trait-borrow branch April 21, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortendahl mortendahl mortendahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkloberdanz @mortendahl