New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC improvements, mTLS, and more #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdragos
reviewed
Oct 26, 2020
rdragos
reviewed
Oct 26, 2020
yanndupis
reviewed
Oct 26, 2020
yanndupis
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mortendahl, excellent work on this 💪 ! I don't have other comments than the one mentioned by Dragos.
As mentioned in your TODOs would be great to have all the examples matching python-functions
example but it can be done in a separate PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does quite a bit:
Executor
andChannelManager
; this captures the fact that the former is used by the orchestrator while the latter is simply an implementation detail of (one way of doing) networkingServer
toWorker
KernelBasedExecutor
toAsyncExecutor
(since they're all likely to be kernel based, but we could have other non-async strategies)python-functions
)watchexec
to automatically restart workers have changes are detected to the source codeTODO:
restarting workers using watchexec should be for development only; maybe separate dev-worker image?update all examples to match(see Update all examples to match python-functions #70)python-functions