Allow excluding patterns #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Jun 17, 2024
tfausak
commented
Jun 18, 2024
| expectDiscover | ||
| [["M.hs"]] | ||
| "library\n -- cabal-gild: discover .\n exposed-modules:" | ||
| "library\n -- cabal-gild: discover .\n exposed-modules: M\n" |
There was a problem hiding this comment.
This is a new test since I changed all the existing discover . to just discover.
tfausak
commented
Jun 18, 2024
| (Either E (), S, W) | ||
| runGild arguments inputs files = | ||
| runTest | ||
| (Gild.mainWith arguments) | ||
| ( Map.fromList inputs, | ||
| Map.mapWithKey (\d fs -> FilePath.combine d <$> fs) $ Map.fromList files | ||
| Map.singleton "." (fmap FilePath.joinPath files) |
There was a problem hiding this comment.
This changed since now walk is only ever called with "." as the first argument.
|
This is arguably a breaking change since you can no longer discover modules outside the current directory, but that never would've worked with Cabal anyway so I don't think it matters. Note that the only special character is |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66.
This is wildly inefficient, which is why it's still a draft. I think the best way forward is to change
MonadWalkto be a wrapper aroundgetDirectoryFilesIgnore. That way I should be able to efficiently support both excluding and including (#67).