Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Update code to run with purs 0.11.7 #114

Merged
merged 4 commits into from
Jan 17, 2018
Merged

Update code to run with purs 0.11.7 #114

merged 4 commits into from
Jan 17, 2018

Conversation

adius
Copy link

@adius adius commented Jan 17, 2018

Hi,
I updated the code to run with the latest version of PureScript.
Luckily it wasn't that bad to upgrade 馃榿.
The updated dependencies are directly defined in the bower.json file.
Do you rather want to update purescript-batteries instead and
import the updated version?

Copy link
Owner

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Obviously I haven't touched this project in a while. In fact, that was already the case a few months ago: #113

Using dependencies directly instead of going through Batteries is fine. When I created this, the idea was that Batteries would be "normal" and Neon would be "weird". In other words, Batteries would be an easy way to use all the default stuff and Neon would be an experimental interface on top of Batteries.

In practice, that's probably not worth it. Batteries inevitably pulls in more than Neon needs. They might also move at different paces. For example, if I still maintained Batteries it would be good for it to always be at the latest version of everything. That's not really the case with Neon.

All that being said, my situation hasn't really changed. I am not in a position to pour effort into the PureScript community or maintain these libraries. If you want to pick up the torch, I would be more than happy to add you as a collaborator.

@adius
Copy link
Author

adius commented Jan 17, 2018

In practice, that's probably not worth it. Batteries inevitably pulls in more than Neon needs. They might also move at different paces

That's what I thought...

If you want to pick up the torch, I would be more than happy to add you as a collaborator.

Sounds cool! I wanted to write a little CLI tool with neon, so I'm around for at least a little 馃榿

First step would be to put it up on Pursuit. Shall I publish it with my account, or do you want to use yours?

@tfausak
Copy link
Owner

tfausak commented Jan 17, 2018

I've added you as a collaborator. If Pursuit lets you upload it under your name, go ahead. Neon used to be on Pursuit but I think the docs have been nuked at least once since then.

@adius adius merged commit 7a8f7ff into tfausak:master Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants