Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use MonadIO to generalise the library a bit. #24

Merged
merged 3 commits into from
Jan 23, 2023
Merged

use MonadIO to generalise the library a bit. #24

merged 3 commits into from
Jan 23, 2023

Conversation

L0neGamer
Copy link
Contributor

No description provided.

@L0neGamer
Copy link
Contributor Author

A couple of parameters (such as ClientApp and Config) still use IO, but there's not much I can do about that without breaking changes/changing something upstream.

tfausak
tfausak reviewed Jan 22, 2023
View reviewed changes
Copy link
Owner

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to follow the lead of the websockets package whenever possible. It doesn't depend on unliftio, so I'm a little hesitant to add it here.

source/library/Wuss.hs Outdated Show resolved Hide resolved
@L0neGamer L0neGamer changed the title use UnliftIO to generalise the library a bit. use MonadIO to generalise the library a bit. Jan 23, 2023
tfausak
tfausak approved these changes Jan 23, 2023
View reviewed changes
Copy link
Owner

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

wuss.cabal Outdated Show resolved Hide resolved
@tfausak tfausak merged commit 1f886b7 into tfausak:main Jan 23, 2023
@L0neGamer L0neGamer deleted the monadclasses branch January 24, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfausak tfausak tfausak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@L0neGamer @tfausak